[5/6] ddraw: fix palette copying when destination palette is NULL

Alexander Dorofeyev alexd4 at inbox.lv
Tue Jan 1 04:19:50 CST 2008

OK, I'll see what I can do with the test. Speaking of tests, I submitted test
for zero vertex rhw case (as suggested by H.Verbeet to avoid future
regressions), but I think it didn't get accepted. Perhaps, you can look through
it and provide some feedback? Would be good to hear the bad news now, before I
submit more wrong stuff (esp. considering that I'm also trying to write a test
for another issue with Aliens vs Predator 1 that I want to fix). I'm attaching
the zero rhw test.

Stefan Dösinger wrote:
> Am Montag, 31. Dezember 2007 12:43:37 schrieb Alexander Dorofeyev:
>> The thing that it tries this copy palette thing at all (AVP1 doesn't depend
>> on that BTW, it does SetPalette on both source and target) - that shouldn't
>> be difficult to test, I think I could write it. Beyond that, I don't know,
>> the documentation on these old interfaces seems non-existant. Is there a
>> way to obtain DX6 docs?
> I suspect that we shouldn't copy the palette at all, I think Texture::Load and 
> friends just copy the bytes over. A test could verify / falsify that. As for 
> the docs, there were older dx docs available on some websites, but I lost the 
> link. I'll see if I can find it.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rhw_zero_test.diff.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080101/0385f399/attachment-0001.txt 

More information about the wine-devel mailing list