Spelling fixes round 6 - resend - don't apply first patch

James McKenzie jjmckenzie51 at sprintpcs.com
Tue Jan 8 19:38:00 CST 2008


Francois Gouget wrote:
>  #ifdef HAVE_UNISTD_H
> -# include <unistd.h>
> +#include <unistd.h>
>  #endif
>  #include <stdarg.h>
>  #include <stdio.h>
>
> I think this chunk should not be applied because:
>  * as pointed out before, it's not a spelling fix
>  * it's perfectly valid to have a space there
>  * the indentation makes the scope of the #ifdef clearer. So removing it 
> makes the code less readable
>
>
>   
Francois:

I am a long time programmer and expect the include to be next to the # 
sign.  However, you are correct in that it does not break code, and if 
it is not broken, why fix?  Is it possible to indent the entire line by 
two spaces (I think it is not)?

James McKenzie




More information about the wine-devel mailing list