[PATCH] check for array index overflows
Marcus Meissner
marcus at jet.franken.de
Tue Jan 15 01:08:36 CST 2008
On Mon, Jan 14, 2008 at 11:57:39PM +0100, H. Verbeet wrote:
> On 14/01/2008, Marcus Meissner <marcus at jet.franken.de> wrote:
> > Hi,
> >
> > This checks for overflowing the fixed size arrays.
> >
> > spotted by Coverity.
> >
> > (Submitted some months ago already, but left in my queue.)
> >
> > Ciao, Marcus
> > ---
> IIRC last time we tested this it was allowed on Windows, and simply
> causes memory corruption.
> If we want to prevent this, we should probably just return WINED3D_OK.
I don't like memory corruption or buffer overflows. ;)
Just sent another patch, returning WINED3D_OK but printing ERR().
Ciao, Marcus
More information about the wine-devel
mailing list