[dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well
Alexandre Julliard
julliard at winehq.org
Fri Jan 18 05:37:13 CST 2008
"Jason Green" <jave27 at gmail.com> writes:
> +
> +#ifdef TRACE_SYMBOL_LIST
> + TRACE("\n\n***** sorting the table {count = %d}\n\n", module->num_sorttab);
> +#endif
> +
> + qsort(module->addr_sorttab, module->num_sorttab, sizeof(struct symbol_entry), symt_cmp_addr_and_size);
> +
> + generateSymbolChains(module);
> +
> +
> +#ifdef TRACE_SYMBOL_LIST
> + if (0){
> + ULONG64 prevAddr = 0;
Please don't add ifdef'ed out code, it should either be compiled always,
or removed completely.
> + sizeof(SYMBOL_INFO), Symbol->SizeOfStruct,
> + (intptr_t)&Symbol->SizeOfStruct - (intptr_t)Symbol,
> + (intptr_t)&Symbol->TypeIndex - (intptr_t)Symbol,
> + (intptr_t)&Symbol->Reserved[0] - (intptr_t)Symbol,
Don't use stdint.h types, there are Win32 types for that.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list