LoadStringW [1/2]

Dmitry Timoshkov dmitry at codeweavers.com
Mon Jan 21 02:38:00 CST 2008

"Dmitry Timoshkov" <dmitry at codeweavers.com> wrote:

> It's not clear what this test is supposed to show. If the 1st call
> to LoadStringW is supposed to set resourcepointer to not NULL, why
> don't you test it? Then 'if(resourcepointer != NULL)' check and copying
> to copiedstring are not needed.
> Also, if the test depends on a later patch to not fail, the test should be
> included in the patch.

Also, you need to test LoadStringA, to see if it behaves similarly. It would be
also interesting to test LoadStringA/W with both buffer and buffer length set
to 0.

In addition, as I already pointed out you need to inspect Wine source and fix
the places which will be broken by your fix.


More information about the wine-devel mailing list