rpcrt4: Fix a test that fails in win2k3

Rob Shearman robertshearman at gmail.com
Wed Jul 2 04:52:11 CDT 2008


2008/7/2 James Hawkins <jhawkins at codeweavers.com>:
> diff --git a/dlls/rpcrt4/tests/ndr_marshall.c b/dlls/rpcrt4/tests/ndr_marshall.c
> index fa19674..abd06dc 100644
> --- a/dlls/rpcrt4/tests/ndr_marshall.c
> +++ b/dlls/rpcrt4/tests/ndr_marshall.c
> @@ -1848,7 +1848,9 @@ static void test_ndr_buffer(void)
>      ok(ret == StubMsg.Buffer, "NdrGetBuffer should have returned the same value as StubMsg.Buffer instead of %p\n", ret);
>      ok(RpcMessage.Handle != NULL, "RpcMessage.Handle should not have been NULL\n");
>      ok(RpcMessage.Buffer != NULL, "RpcMessage.Buffer should not have been NULL\n");
> -    ok(RpcMessage.BufferLength == 10, "RpcMessage.BufferLength should have been 10 instead of %d\n", RpcMessage.BufferLength);
> +    ok(RpcMessage.BufferLength == 10 ||
> +       RpcMessage.BufferLength == 12, /* win2k3 */
> +       "RpcMessage.BufferLength should have been 10 or 12 instead of %d\n", RpcMessage.BufferLength);
>      ok(RpcMessage.RpcFlags == 0, "RpcMessage.RpcFlags should have been 0x0 instead of 0x%lx\n", RpcMessage.RpcFlags);
>      ok(StubMsg.Buffer != NULL, "Buffer should not have been NULL\n");
>      ok(!StubMsg.BufferStart, "BufferStart should have been NULL instead of %p\n", StubMsg.BufferStart);

I think the behaviour on win2k3 should be marked as broken, since I
can't see any reason why it would need to return more bytes than was
requested.

-- 
Rob Shearman



More information about the wine-devel mailing list