Tests and Valgrinding

Alexandre Julliard julliard at winehq.org
Wed Jul 2 10:46:21 CDT 2008


"Dan Kegel" <dank at kegel.com> writes:

> As a first step, James and I could (along with posting the errors
> to wine-devel) also post patches to revert the guilty changes.
> (And if we do it quickly enough, perhaps Alexandre can
> do the revert on the same day...)
> Then the author could fix and resubmit.
> How's that sound?

I'm not going to revert patches just because they introduce a valgrind
warning, that would make a big mess of the history. If you can spot the
error before the patch goes in, great, otherwise you need to submit a
fix, not a revert.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list