RFC: More tests for riched20 ITextServices
Austin Lund
austin.lund at gmail.com
Thu Jul 3 21:16:18 CDT 2008
>>> + extern typeof(func) THISCALL(func); \
>>> + __ASM_GLOBAL_FUNC(__thiscall_ ## func, \
>>> + "popl %eax\n\t" \
>>> + "pushl %ecx\n\t" \
>>> + "pushl %eax\n\t" \
>>> + "jmp " __ASM_NAME(#func) )
>>
>> I would comment on the use of typeof, being a GCC extension, it should
>> be avoided. I don't know why it's in the source already; unless we are
>> allowing them now maybe it just slipped by.
>
> I guess the function prototype could be taken out of the #define and
> each function given its own definition. I'm not sure if this is a
> good idea. Such is the evil of the conversion to thiscall.
>
OK. I put in all the individual prototypes for the thiscall functions.
Revised patches attached.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-richedit-Added-conformance-tests-for-txtsrv.c.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080704/1ccdb423/attachment-0004.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-richedit-Added-tests-for-TxSetText-and-TxGetText-in-t.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080704/1ccdb423/attachment-0005.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-richedit-Added-tests-for-simple-strings-for-TxGetNatu.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080704/1ccdb423/attachment-0006.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-richedit-Added-a-test-for-TxDraw-in-txtsrv.c.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080704/1ccdb423/attachment-0007.txt
More information about the wine-devel
mailing list