Patch feedback

Lei Zhang thestig at
Sun Jul 6 12:27:26 CDT 2008

On Sun, Jul 6, 2008 at 6:55 AM, Alexander Nicolaysen Sørnes
<alex at> wrote:
> Hello,
> I would really appreciate any feedback as to how these patches can be improved
> so that they will be accepted into Wine.
> regedit: Add support for importing Unicode files
> I know this patch is a little big, but I'm not sure how it could be split up
> without possible data loss on import.  Is that acceptable?  I could for
> instance make a first patch that merely reads the file as Uncode then
> converts each line to multibyte characters.

Sure. How about:

1 patch for the first two utility functions.
1 patch for each W version of an existing function.
1 or 2 patches to glue it all together.

More information about the wine-devel mailing list