[PATCH 2/5] dinput: Stop and unload effect when freeing it.

Daniel Remenak dtremenak at gmail.com
Mon Jul 7 13:38:56 CDT 2008

On Sat, Jul 5, 2008 at 9:24 PM, Vitaliy Margolen
<wine-patches at kievinfo.com> wrote:
> +        LinuxInputEffectImpl_Stop(iface);
> +        LinuxInputEffectImpl_Unload(iface);


Native behavior is for Unload to stop the effect also (see msdn or
test it yourself), so the call to Stop here is unnecessary.  If the
call to Stop is required, it must be done in Unload, not Release, as
it's not unusual to unload an effect without releasing it when a game
has a large number of available effect instances.

It is my understanding that no explicit call to Stop is needed, either
in Release or Unload, as evdev has the same behavior documented (see
section 3.3 of ff.txt in the kernel docs).

The call to Unload is certainly correct, and I don't think there's
anything strictly wrong with calling Stop; just make sure it's not
covering up a bug in Unload.

Daniel Remenak

More information about the wine-devel mailing list