[dplayx 02/29] Tests for DirectPlayCreate

[Kai Blin]

On Wednesday 09 July 2008 19:15:34 Ismael Barros wrote:
>
> >> +    heap = HeapCreate( 0, 0, 0 );
> >
> > Do you have any reason to create your own heap? Each windows process
> > already comes equipped with a standard heap you can obtain using the API

> That's what I used in the begining, but I've got some HeapAllocs that
> I don't free. This is intended, as freeing that memory would make the
> code unnecessarily complex, I can't use static local variables (I use
> the result of the function inside the same ok() or trace()), and
> loosing memory is always undesirable but not critical in a test case.
> The main problem was to get yelled when valgrind complains about the
> memory leak, and Kai Blin advised me to use my own heap to avoid
> valgrind complains.
> Anyway is this is too dirty I'll have no problem in doing it "correctly".

This might just be me getting used to Samba's libtalloc too much, but what 
downside is there to allocate all memory for a test case on one heap and just 
freeing that once you're done?

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080709/a9452537/attachment.pgp