taskmgr: Add full translation [1/2]

Detlef Riekenberg wine.dev at web.de
Sun Jul 20 18:14:07 CDT 2008

On So, 2008-07-20 at 22:58 +0500, Vladimir Pankratov wrote:

First of all, your Idea is great, but your Patch is far to large.
Please move only some strings (usual is from one source file)
to the resources at once.

Then you must keep the resources in sync.
That means, when you move one string to the resources, you must add
that string to all rc files (most times as english string).
Check the patch-size here. It might be useful to split the
string-move for one source-file to the resources in more than one patch.

The strings in the Menu and Dialogs are already in the resources
and translated. You must not remove them.
As a hint for your first removed item:
  grep ID_VIEW_LARGE programs/taskmgr/*.rc

> +    TCHAR     szLoadedString[250];
> +    TCHAR     szTemp[250];
> +            LoadStringA(hInst, IDS_UNABLE_TO_ACCESS, szLoadedString,
> sizeof(szLoadedString));
> +            MessageBox(hMainWnd, strErrorText, szLoadedString, MB_OK|

We try to avoid TCHAR and change our Apps to Unicode.
When you add code to move the strings to the resources, please use
WCHAR and the Unicode functions

As a note, switching to unicode later (-DUNICODE -D_UNICODE) breaks
with the code from your Patch.
When you compare TCHAR, LoadStringA and MessageBox for ANSI and UNICODE,
you see, why '#include <tchar.h>' should be forbidden.

Thanks for helping Wine.

By by ... Detlef

More information about the wine-devel mailing list