[Gdiplus try2 02/16] Implement GdipCreateRegion

Huw Davies huw at codeweavers.com
Mon Jul 21 16:08:46 CDT 2008


Adam Petaccia wrote:
 >@@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region)
 >
 >     if(!(calls++))
 >         FIXME("not implemented\n");
 >+    TRACE("%p\n", region);
 >+
 >+    GdipDeleteRegion(region);
 >+    GdipCreateRegion(&region);
 >+    region->node->type = RegionDataEmptyRect;
 >
 >     return NotImplemented;
 > }

This is still wrong.  You probably don't even want to implement 
GdipSetEmpty in this patch anyway.

In general you may be better off submitting a smaller patch series 
rather than 16 patches in one go.

Huw.



More information about the wine-devel mailing list