[Gdiplus try2 02/16] Implement GdipCreateRegion
Adam Petaccia
adam at tpetaccia.com
Mon Jul 21 16:51:15 CDT 2008
On Mon, 2008-07-21 at 22:08 +0100, Huw Davies wrote:
> Adam Petaccia wrote:
> >@@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region)
> >
> > if(!(calls++))
> > FIXME("not implemented\n");
> >+ TRACE("%p\n", region);
> >+
> >+ GdipDeleteRegion(region);
> >+ GdipCreateRegion(®ion);
> >+ region->node->type = RegionDataEmptyRect;
> >
> > return NotImplemented;
> > }
>
> This is still wrong. You probably don't even want to implement
> GdipSetEmpty in this patch anyway.
Ug, that's a user problem in dealing with histories with git. The
behavior was corrected in a later patch in the series. Is there anything
else wrong with the patch series? If not I'll resend with this issue
straightened out.
>
> In general you may be better off submitting a smaller patch series
> rather than 16 patches in one go.
>
> Huw.
More information about the wine-devel
mailing list