dpnet: #3 Add stubbed DirectPlay8Peer:Close

Alexander Nicolaysen Sørnes alex at thehandofagony.com
Mon Jul 28 06:02:40 CDT 2008


På Mandag 28 juli 2008 , 12:14:44 skrev Alexandre Julliard:
> Alexander Nicolaysen Sørnes <alex at thehandofagony.com> writes:
> > +
> >  static const IDirectPlay8PeerVtbl DirectPlay8Peer_Vtbl =
> >  {
> >      IDirectPlay8PeerImpl_QueryInterface,
> >      IDirectPlay8PeerImpl_AddRef,
> >      IDirectPlay8PeerImpl_Release,
> >      IDirectPlay8PeerImpl_Initialize,
> > -    IDirectPlay8PeerImpl_EnumServiceProviders
> > +    IDirectPlay8PeerImpl_EnumServiceProviders,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    NULL,
> > +    IDirectPlay8PeerImpl_Close
>
> Don't do that, partial vtables lead to hard to find crashes. The vtable
> should be completely initialized from the start with stub functions.

Thanks, I will send a new patch.


Alexander N. Sørnes



More information about the wine-devel mailing list