Device.c and set render states

Stefan Dösinger stefan at
Mon Jul 28 08:57:59 CDT 2008

My performance concern is about the switch statement itself, less about the
actual value checking. If you have something like

switch(renderstate) {
	case WINED3DRS_A:
	case WINED3DRS_B:

	default: break;

The binary code generated by the compiler still checks 239 states against
D3DRS_A and D3DRS_B(the only exception is D3DRS_A, which is never compared
against D3DRS_B). That is where my worries come from, not the doSomething()

But beyond that, I think checking the value ranges is just wrong, at least
we need a test to show Windows does that as well.

More information about the wine-devel mailing list