[WideChar conversion improvements - 5/5] Add a lot ofWideCharToMultiByte tests

Vitaliy Margolen wine-devel at kievinfo.com
Mon Jul 28 09:14:24 CDT 2008


Colin Finck wrote:
> Vitaliy Margolen wrote:
>> You have to do that in the patch that fixes the test. Each patch have to 
>> be
>> autonomous and have all tests pass before and after it.
> 
> Well, I just found out that this test passes now by accident.
> And I also marked all my patches as one bunch consisting of 5 patches like 
> other people do here as well.
> 
> Of course, I could resend everything now simply for moving one change into 
> another patch, but I think this will just make things more complex and flood 
> this mailing list.

No you have to make each patch complete. If you left mandatory pieces out - 
that patch will be refused.

So yes you do need to regenerate the whole set and re-send it.

Vitaliy.



More information about the wine-devel mailing list