[PATCH 1/5] quartz: Add tests for Video Mixing Renderer 9

Alexandre Julliard julliard at winehq.org
Wed Jul 30 08:10:53 CDT 2008


"Maarten Lankhorst" <m.b.lankhorst at gmail.com> writes:

> From f3544f718dbebd3dca29d94dbbcbdd071884e5a6 Mon Sep 17 00:00:00 2001
> From: Maarten Lankhorst <m.b.lankhorst at gmail.com>
> Date: Mon, 28 Jul 2008 18:18:06 -0700
> Subject: [PATCH] quartz: Add tests for Video Mixing Renderer 9
>
> ---
>  dlls/quartz/tests/Makefile.in |    5 +-
>  dlls/quartz/tests/null.h      |  667 +++++++++++++++++++++++++++++

You should put that code in the C file, it doesn't belong in a header,
especially since you are not using anywhere else. Building tests
stand-alone is a nice to have, but it's not worth the cost of putting
half the code in a header.

> +#define trace_save trace
> +
> +/* Don't debug null by default */
> +#define debug(...) do { } while (0)

Vararg macros are not portable.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list