[1/2] user32: Add a test for ToUnicode (try 5)
Paul Vriens
paul.vriens.wine at gmail.com
Thu Jul 31 11:52:32 CDT 2008
Andre Wisplinghoff wrote:
> Wrapping was still wrong. Sorry for that. Just using attachments now.
>
> dlls/user32/tests/input.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 files changed, 37 insertions(+), 0 deletions(-)
>
>
> ------------------------------------------------------------------------
>
>
Just some things that caught my attention:
Could you trim the length for some of the lines somewhat? I also don't think you
need all those comments in the first call to ToUnicode.
There is a C++ comment in the patch, should be avoided.
And as a last one, is it possible to use names instead of magic constants?
--
Cheers,
Paul.
More information about the wine-devel
mailing list