Fixing crashes in Tests (OS version check)
fgouget at free.fr
Sun Jun 1 08:29:05 CDT 2008
On Sat, 31 May 2008, Juan Lang wrote:
> > An example of one that fails is
> > ret = SnmpUtilOidToA(NULL);
> > Under win98, this function is valid to call, but will crash if you call
> > it will a NULL parameter. I don't think removing this test a good idea,
> > since we are setting XP as a base, at this passes.
> I disagree that the test shouldn't be removed. The tests are meant to
> show Windows behavior that apps are likely to expect.
The thing is that this evolves with time. Back in 2000 nobody would have
called SnmpUtilOidToA with a NULL parameter as it would have meant
crashing on a lot of the Windows install base. Nowadays every ISV
expects you to have at least Windows XP and wouldn't care one bit if
that call means crashing the application on NT4 or lower.
So you could say that nowadays applications are likely to expect
SnmpUtilOidToA(NULL) not to crash which means keeping these tests.
However I don't think our conformance tests should crash on older
systems and that's what makes things tricky...
Francois Gouget <fgouget at free.fr> http://fgouget.free.fr/
Broadcast message : fin du monde dans cinq minutes, repentez vous !
More information about the wine-devel