Crash in test d3d9:stateblock with warn+heap is a wine bug

[Michael Karcher]

Am Montag, den 02.06.2008, 06:23 -0400 schrieb Ivan Gyurdiev:
> Ivan Gyurdiev wrote:
> > Michael Karcher wrote:
> >> Does anyone knows whether the test has this been written buggy on
> >> purpose (some app does this), or it is by accident?
> >>
> I guess the reason why switching the render target was tested in 
> particular was some weird code manipulating the stateblock when Wine was 
> switching rendertargets, which I was interested in testing. The last 
> event sequence should probably be dropped if it's invalid, but I would 
> keep the rest, since the test has uncovered a number of bugs in the past.

Oh, everything is valid, except for the IUnknown_Release(swapchain) in
switch_render_target. It must not happen before the render target gets
reverted in revert_render_target. That means, a IDirect3DSwapchain9
variable has to be added to the event_data block to keep the pointer
between switch_render_target and revert_render_target.

Today, I am on high workload on my paid job, so don't expect a patch
until 23:00 CEST. Feel free to fix it yourself, if you want.

Regards,
  Michael Karcher