wininet: Make sure URL is terminated in InternetCrackUrlA.

[Francois Gouget]

On Tue, 10 Jun 2008, Hans Leidekker wrote:

> On Monday 09 June 2008 17:09:52 Alexandre Julliard wrote:
> 
> > The bug is in InternetCrackUrlW, it shouldn't require the string to be
> > null-terminated.
> 
> Right, but I guess fixing that is no 1.0 material since there's at least
> 4 places where it assumes a null-terminated string, including a call to
> InternetCanonicalizeUrlW.

Why not? It's a bug fix and four places to fix sounds quite reasonable 
(>100 may not be). Maybe it's just me but I didn't feel like 1.0 would 
entail a deep deep freeze period where only critical/security bugs would 
be fixed.

Also I don't feel that the current state of Wine (or of the future Wine 
1.0) is such a marvel of perfection that it justifies a deep freeze to 
make sure it's not going to get a tiny little scratch here or there.

So my understanding is that yeah, we're not going to introduce any big 
new functionality (DirectX 10 is out), or rewrite core parts of Wine 
(the DIB engine is out), or put the code through a prettifier, or switch 
to a new version control system (we're using Git already anyway). But 
this sounds like pretty regular bug fixing to me (unless I got the scope 
wrong).


-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.