wininet: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported

Lei Zhang thestig at google.com
Wed Jun 25 11:02:45 CDT 2008


On Wed, Jun 25, 2008 at 8:46 AM, Alexander Morozov <amorozov at etersoft.ru> wrote:
> Changelog:
> InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported
>
> From b89937296efd5a45772027f07b2fdbf80b5f480d Mon Sep 17 00:00:00 2001
> From: Alexander Morozov <amorozov at builder.office.etersoft.ru>
> Date: Wed, 25 Jun 2008 19:07:34 +0400
> Subject: [PATCH] wininet: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported
>
> ---
>  dlls/wininet/dialogs.c       |    2 +-
>  dlls/wininet/tests/dialogs.c |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c
> index cf6ee5c..1ea9b9c 100644
> --- a/dlls/wininet/dialogs.c
> +++ b/dlls/wininet/dialogs.c
> @@ -385,5 +385,5 @@ DWORD WINAPI InternetErrorDlg(HWND hWnd, HINTERNET hRequest,
>         FIXME("Need to display dialog for error %d\n", dwError);
>         return ERROR_SUCCESS;
>     }
> -    return ERROR_INVALID_PARAMETER;
> +    return ERROR_NOT_SUPPORTED;
>  }
> diff --git a/dlls/wininet/tests/dialogs.c b/dlls/wininet/tests/dialogs.c
> index 088ba01..168053f 100644
> --- a/dlls/wininet/tests/dialogs.c
> +++ b/dlls/wininet/tests/dialogs.c
> @@ -66,7 +66,6 @@ static void test_InternetErrorDlg(void)
>
>     ret = InternetErrorDlg(GetDesktopWindow(), hr,
>             ERROR_FILE_NOT_FOUND, 0, NULL);
> -    todo_wine
>     ok(ret == ERROR_NOT_SUPPORTED, "InternetErrorDlg failed\n");
>
>     end_thread = 0;
> --
> 1.5.4.5.GIT
>
>
>
>
>

Patches go to wine-patches at winehq.org, not wine-devel at winehq.org.



More information about the wine-devel mailing list