Revert "winspool.drv: Make sure the printer driver registry entry exists.

Huw Davies huw at codeweavers.com
Wed Jun 25 11:24:54 CDT 2008


On Wed, Jun 25, 2008 at 11:28:35AM +0100, Huw Davies wrote:
> On Wed, Jun 25, 2008 at 12:17:36AM +0200, Detlef Riekenberg wrote:
> > On Di, 2008-06-24 at 10:25 -0700, Dan Kegel wrote:
> > > Today I started getting a heap corruption and crash in localspl:
> > > ...
> > > Anyone know what's up with that?
> > 
> > That was introduced by Huw (added a circular dependance).
> > 
> > Changelog:
> > Revert "winspool.drv: Make sure the printer driver registry entry
> > exists.
> > 
> 
> But won't we still get the same problem when a new printer (and its
> driver) are added?  In which case we should fix that rather than
> hiding the issue.

Indeed, if you run the localspl test with a yet undiscovered cups
printer you get the same problem.  I've sent a hack to wine-patches
that ensures that winspool.drv is loaded before spoolss in the test.
That should be removed once the circular dependency is fixed.

No real app will load localspl before winspool.drv so this'll not hit
us in the real world.

Huw.
-- 
Huw Davies
huw at codeweavers.com



More information about the wine-devel mailing list