Gdiplus [1/3] Improve accuracy in calculating height

[Adam Petaccia]

On Fri, 2008-06-27 at 16:46 +0200, Michael Karcher wrote:
> Am Freitag, den 27.06.2008, 15:27 +0100 schrieb Huw Davies:
> > >  static const REAL mm_per_pixel = 25.4;
> > > +static const REAL points_per_inch = 1/72;
> > >  
> > 
> > I know there are several definitions of a point, but none are this big!
> > 
> > points_per_inch should be around 72.
> 
> And if this is code is compiled by a C compiler, you get
> points_per_pixel=0, as 1 and 72 are integers, so 1/72 is an integer
> division that yields zero. This zero *then* gets converted to REAL. You
> probably mean points_per_inch = 72 or inches_per_point = 1./72 (note the
> decimal dot!)
Face, meet palm. Thank you. I think this went uncaught because 0
indicates a default value.  

I'll resend this as well as some other function which got negatively
affected by a cleanup patch -- and after lots of valgrinding (making
sure that 3rd time is in fact a charm).

> 
> Regards,
>   Michael Karcher
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080627/c5f0e0b1/attachment.pgp