wined3d: Check with "&& FALSE"

Paul Vriens paul.vriens.wine at gmail.com
Mon Mar 17 07:48:30 CDT 2008


H. Verbeet wrote:
> On 17/03/2008, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
>> Hi,
>>
>>  In the past we had some occurrences of comparisons with NULL flags. I had this
>>  check run again today and it came back with:
>>
>>  ./dlls/wined3d/arb_program_shader.c:316:         if(max_constantsF +
>>  extra_constants_needed + 1 < GL_LIMITS(pshader_constantsF) && FALSE) {
>>
>>  Is this line correct? Doesn't this alway return FALSE?
>>
> Looks like leftover debug code to me.
> 
Hi,

This is the commit responsible for this change:

commit 6313e0ffff5f57e437937e17fa482694d17d9664
Author: Stefan Dösinger <stefan at codeweavers.com>
Date:   Fri Sep 14 13:02:59 2007 +0200

     wined3d: SRGB write correction emulation.

-- 
Cheers,

Paul.



More information about the wine-devel mailing list