[Tools 6/6] winetest: Issue a better description than '.' for the special failure modes. Write them as a note so they stand out better.

Paul Vriens paul.vriens.wine at gmail.com
Mon Mar 17 11:21:51 CDT 2008


Francois Gouget wrote:
> ---
>  winetest/gather |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/winetest/gather b/winetest/gather
> index b502345..ee49f4a 100755
> --- a/winetest/gather
> +++ b/winetest/gather
> @@ -329,21 +329,21 @@ sub singletest($$$) {
>  EOF
>      } elsif ($count eq "winetest crash") {
>          print OUT <<"EOF";
> -      <td class="result fail also-skip"><a
> +      <td class="note"><a
>          title="Test did not run as winetest crashed"
> -        >.</a></td>
> +        >winetest</a></td>
>  EOF
>      } elsif ($count eq "file limit") {
>          print OUT <<"EOF";
> -      <td class="result fail also-skip"><a
> +      <td class="note"><a
>          title="Test is missing because of a partial report file"
> -        >.</a></td>
> +        >truncated</a></td>
>  EOF
>      } elsif ($count eq "test missing") {
>          print OUT <<"EOF";
> -      <td class="result fail also-skip"><a
> +      <td class="note"><a
>          title="Test did not run for an unknown reason"
> -        >.</a></td>
> +        >not run</a></td>
>  EOF
>      } else {
>          my $class = $error?"fail":$todo?"todo":"pass";
Hi Francois,

We currently have these single '.' also when there are multiple failures for an 
OS that are actually the same failures.

For example the missing dll's. There are several dll's missing on win95 and 
win98 so it would be nice to have this reflected in the group piece of the page. 
I think green with a blue border looks much nicer than the single '.' we are 
currently having. Other thoughts?

The new page layout is now present and I must say it looks better although Wine 
looks a bit worse now because all the green is gone :-).

-- 
Cheers,

Paul.



More information about the wine-devel mailing list