kernel32: WideCharToMultiByte: return error on negative dest len (take 2)
mstefani at redhat.com
Wed Mar 26 08:38:07 CDT 2008
Dan Kegel wrote:
> On Wed, Mar 26, 2008 at 4:04 AM, Michael Stefaniuc <mstefani at redhat.com> wrote:
>> > This would require reviewing all uses of WideCharToMultiByte in Wine,
>> > many places get this wrong. Unless you have an app that requires this
>> > fix I'd suggest to leave the test as todo_wine for now.
>> Would that be a good janitorial work to be done before Wine 1.0? I feel
>> like I'm getting tired of translating ...
> Sure. A quick grep finds some obvious ones:
> $ find . -name '*.c' | xargs grep WideCharToMultiByte | grep ' -1, NULL, NULL)'
> The first step, as Alexandre says, is to add the test with a todo_wine
> around the negative destlen test.
> I would have done it but I'm more than happy to let you run with it.
Please go ahead and resubmit the patch with todo_wine around it. I don't
want to claim ownership for the patch you wrote.
More information about the wine-devel