[Tools 5/6] winetest: Add statistics for the number of unit tests with errors or todos.

Paul Vriens paul.vriens.wine at gmail.com
Fri Mar 28 03:55:29 CDT 2008


Paul Vriens wrote:
> Francois Gouget wrote:
>> Also tweak the headers and footers a bit.
>> ---
>>
>> This gives us a better idea of how many unit tests are failing.
>>
>>  winetest/gather |   67 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++----
>>  1 files changed, 62 insertions(+), 5 deletions(-)
>>
>> diff --git a/winetest/gather b/winetest/gather
> 
> Hi Francois,
> 
> I think something is 'wrong' with the statistics for the Wine group:
> 
> http://test.winehq.org/data/200803211000/#group_Wine
> 
> They are the same for every box with respect to the "X + Y". The title 
> (on mouse  over) is correct though.
> 

Would this do? :

diff --git a/winetest/gather b/winetest/gather
index 294ad06..fdacff5 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -362,7 +362,7 @@ EOF
                      "pass";
          my $count=!$report->{todos} ? $report->{errors} :
                    !$report->{errors} ? $report->{todos} :
-                  "$group->{errors}+$group->{todos}";
+                  "$report->{errors}+$report->{todos}";

          my $prcnt=!$report->{todos} ? percent($report->{errors}, $unit_count) :
                    !$report->{errors} ? percent($report->{todos}, $unit_count) :


-- 
Cheers,

Paul.



More information about the wine-devel mailing list