kernel32: Implementation of GetLargestConsoleWindowSize.

[Eric Pouech]

Reijo T Sund a écrit :
> >From e59f5ec4eaf6936b7ecb6e4d0a471d38622f22aa Mon Sep 17 00:00:00 2001
> From: Reijo Sund <reijo.sund at helsinki.fi>
> Date: Thu, 1 May 2008 10:20:19 +0300
> Subject: kernel32: Implementation of GetLargestConsoleWindowSize.
>
> The function should return the largest size instead of hard coded
> constants. A fix for the bug 10919.
>   
first of all, implementing twice the same function is a bad idea
you should wrap the two implementations into a single function, and have 
simple wrappers for handling the different return convention
in the other items:
- you never handle errors in return from server calls
- where do the 2 (resp 3) factors come from ?
A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)