[PATCH] check for iface->ref to avoid crash

Marcus Meissner meissner at suse.de
Wed May 7 06:33:42 CDT 2008


On Wed, May 07, 2008 at 11:17:02AM +0100, Robert Shearman wrote:
> Marcus Meissner wrote:
>> @@ -742,6 +742,9 @@ static void write_c_method_def(FILE *header, const 
>> type_t *iface)
>>   static void write_c_disp_method_def(FILE *header, const type_t *iface)
>>  {
>> +  if (!iface->ref) {
>> +    error_loc("write_c_disp_method_def: no reference on interface(%p)\n", 
>> iface);
>> +  }
>>    do_write_c_method_def(header, iface->ref, iface->name);
>>  }
>>   
>
> This can't ever happen. dispinterfaces always derive from IDispatch:
>> dispinterfacehdr: attributes dispinterface      { attr_t *attrs;

I marked it as FALSE in Coverity then.

Ciao, Marcus



More information about the wine-devel mailing list