Fwd: shell32: fix SHFileOperation copying to an empty file list

[Vincent Povirk]

Grr, forgot to copy list.

---------- Forwarded message ----------
From: Vincent Povirk <madewokherd+d41d at gmail.com>
Date: Sat, May 31, 2008 at 9:46 PM
Subject: Re: shell32: fix SHFileOperation copying to an empty file list
To: James Hawkins <truiken at gmail.com>


On Sat, May 31, 2008 at 9:42 PM, James Hawkins <truiken at gmail.com> wrote:
> I'm not either.  There's a very simple way to implement this.  Also,
> you need to add tests for the FO_MOVE action as well.
Do tell, sir.

None of the other operations actually succeed when the destination is
an empty list (except delete of course). I can add tests for them to
ensure they don't crash, but it seems unnecessary.

> @@ -131,6 +132,7 @@ static void clean_after_shfo_tests(void)
>     DeleteFileA("test3.txt");
>     DeleteFileA("test_5.txt");
>     DeleteFileA("one.txt");
> +    DeleteFileA("filename.tex");
>     DeleteFileA("test4.txt\\test1.txt");
>     DeleteFileA("test4.txt\\test2.txt");
>     DeleteFileA("test4.txt\\test3.txt");
>
> typo, and why didn't you stick with the convention used for all the
> other test files (.txt, not .text)?
This was intentional. It was to show that extensions are trimmed to
three characters in this case.

--
Vincent Povirk



-- 
Vincent Povirk