Henri Verbeet : ddraw: Make sure pWineDirect3DCreate and pWineDirect3DCreateClipper match the header .

Henri Verbeet hverbeet at gmail.com
Mon Nov 3 02:35:11 CST 2008


2008/11/3 Rob Shearman <robertshearman at gmail.com>:
> 2008/10/24 Alexandre Julliard <julliard at winehq.org>:
>> diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h
>> index 7ff3c5c..cd1ce15 100644
>> --- a/dlls/ddraw/ddraw_private.h
>> +++ b/dlls/ddraw/ddraw_private.h
>> @@ -414,8 +414,7 @@ struct IDirectDrawClipperImpl
>>
>>  const IDirectDrawClipperVtbl IDirectDrawClipper_Vtbl;
>>
>> -typedef IWineD3DClipper* (WINAPI *fnWineDirect3DCreateClipper)(IUnknown *);
>> -fnWineDirect3DCreateClipper pWineDirect3DCreateClipper;
>> +typeof(WineDirect3DCreateClipper) *pWineDirect3DCreateClipper;
>
> This isn't portable to some compilers, like MSVC. Can this be reverted?
>
Sure, although you'd have to change the type of fnWineDirect3DCreate,
since it has changed since that patch. I'm not sure if it would help
much though, we use typeof in lots of other places in Wine as well.



More information about the wine-devel mailing list