d3dx9: Add ID3DXSprite tests (review please)

Dmitry Timoshkov dmitry at codeweavers.com
Sun Nov 16 19:58:31 CST 2008


"Vitaliy Margolen" <wine-devel at kievinfo.com> wrote:

> In all of your patch:
>> +    if(!obj) return 0;
> Please add space after "if" to make it consistent and more readable:
>    if (!obj) return 0;

Actually it would be better to either completely remove that line,
or even do an assert(obj != NULL) instead IMO.

-- 
Dmitry.



More information about the wine-devel mailing list