dlls/cabinet: fix dead stores (llvm/clang)
Marcus Meissner
meissner at suse.de
Tue Nov 18 03:17:46 CST 2008
On Tue, Nov 18, 2008 at 03:11:52PM +0800, Dmitry Timoshkov wrote:
> "ricardo filipe" <ricardo_barbano at hotmail.com> wrote:
>
> > --- a/dlls/cabinet/fci.c
> > +++ b/dlls/cabinet/fci.c
> > @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT cb, CHECKSUM seed)
> > case 2:
> > ul |= (((ULONG)(*pb++)) << 8);
> > case 1:
> > - ul |= *pb++;
> > + ul |= *pb;
> > default:
> > break;
> > }
>
> Is there any reason that you ignored 2 similar cases above?
Yes, because it would be wrong ... Its a Duffs Device, falling through
to the last case. The other pb++ are necessary.
Ciao, Marcus
More information about the wine-devel
mailing list