Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."
wine-devel at kievinfo.com
Mon Nov 24 14:33:14 CST 2008
Reece Dunn wrote:
> 2008/11/24 Vitaliy Margolen <wine-patches at kievinfo.com>:
>> Since Jacek did not comment on the bug 14311, revert patch in question. It
>> restores 100% functionality of the scrollbars in Steam.
> This is not the correct fix. Simply reverting a patch because it broke
> an application without understanding why is not the right way to go.
IMHO if the author of the patch didn't bother to even write a single comment
to the bug his patch introduced, this patch have to be reverted. Of course
if you have a better fix send a patch in. My patch makes Steam usable again.
> In this case, some applications
> (http://bugs.winehq.org/show_bug.cgi?id=13459) specify the
> DOCHOSTUIFLAG_SCROLL_NO flag to specifically not show any scrollbars.
> In the case of bug 13459, the intro page does not render correctly if
> scrollbars are shown (and on Windows you don't see any scrollbars).
Having extra scrollbars are lesser of the problem then not having them at all!
> What is the behaviour on Windows? Can you explain comments 3 and 8?
Install Steam and see for yourself if you didn't understand a simple comment
I didn't wrote the patch and don't know what all it fixes. I know what it
broke - Steam. Which is one of the most used applications in Wine.
More information about the wine-devel