[1/5] msxml3/tests: Valgrind fix.
James Hawkins
truiken at gmail.com
Mon Oct 6 19:31:41 CDT 2008
On Mon, Oct 6, 2008 at 5:48 PM, Michael Karcher
<wine at mkarcher.dialup.fu-berlin.de> wrote:
> sName is an uninitialized pointer if GetMemberName faild.
> ---
> dlls/msxml3/tests/domdoc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
> index 1ad168b..0703f3d 100644
> --- a/dlls/msxml3/tests/domdoc.c
> +++ b/dlls/msxml3/tests/domdoc.c
> @@ -1565,7 +1565,8 @@ static void test_getElementsByTagName(void)
>
> r = IDispatchEx_GetMemberName(dispex, dispid, &sName);
> ok(r == E_NOTIMPL, "expected E_NOTIMPL got %08x\n", r);
> - SysFreeString(sName);
> + if( !FAILED(r) )
> + SysFreeString(sName);
>
aka SUCCEEDED(r).
--
James Hawkins
More information about the wine-devel
mailing list