Jacek Caban : mshtml: Added IHTMLElement3 stub implementation.
Michael Stefaniuc
mstefani at redhat.com
Wed Oct 8 13:48:05 CDT 2008
Hello Jacek,
Smatch complains about unreachable code introduced by this patch:
Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 536fac7c1b4ef7f6f124d7f3100d3284313f3018
> URL: http://source.winehq.org/git/wine.git/?a=commit;h=536fac7c1b4ef7f6f124d7f3100d3284313f3018
>
> Author: Jacek Caban <jacek at codeweavers.com>
> Date: Tue Oct 7 14:44:18 2008 -0500
>
> mshtml: Added IHTMLElement3 stub implementation.
>
> ---
>
> dlls/mshtml/Makefile.in | 1 +
> dlls/mshtml/htmlelem.c | 4 +
> dlls/mshtml/htmlelem3.c | 447 ++++++++++++++++++++++++++++++++++++++++++
> dlls/mshtml/mshtml_private.h | 3 +
> dlls/mshtml/tests/dom.c | 14 ++
> 5 files changed, 469 insertions(+), 0 deletions(-)
>
> Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=536fac7c1b4ef7f6f124d7f3100d3284313f3018
diff --git a/dlls/mshtml/htmlelem3.c b/dlls/mshtml/htmlelem3.c
new file mode 100644
index 0000000..f85b065
--- /dev/null
+++ b/dlls/mshtml/htmlelem3.c
...
+
+static HRESULT WINAPI HTMLElement3_put_disabled(IHTMLElement3 *iface,
VARIANT_B
+{
+ HTMLElement *This = HTMLELEM3_THIS(iface);
+ FIXME("(%p)->(%x)\n", This, v);
+ return S_OK;
+ return E_NOTIMPL;
+}
+
...
I would say to remove the S_OK return but I really don't know what is
the best here.
thanks
bye
michael
More information about the wine-devel
mailing list