actxprxy/qmgrprxy: Specify dlldata.c in C_SRCS instead of in EXTRA_OBJS to allow dependencies to be generated.

Rob Shearman robertshearman at gmail.com
Thu Oct 9 09:22:29 CDT 2008


2008/10/9 Alexandre Julliard <julliard at winehq.org>:
> "Rob Shearman" <robertshearman at gmail.com> writes:
>
>> @@ -6,9 +6,9 @@ MODULE    = actxprxy.dll
>>  IMPORTS   = rpcrt4 kernel32 ntdll
>>  EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0xb8da6310, 0xe19b, 0x11d0, { 0x93, 0x3c, 0x00, 0xa0, 0xc9, 0x0d, 0xca, 0xa9 } }"
>>
>> -EXTRA_OBJS = dlldata.o
>> -
>> +# Note: dlldata.c is auto-generated
>>  C_SRCS = \
>> +     dlldata.c \
>>       usrmarshal.c
>
> This is wrong, C_SRCS is for source files only. Dependencies for
> dlldata.c are already generated automatically anyway.

Yes, I have verified that by looking at the dependencies in the
makefile for these DLLs. I did check this before sending the patch,
but I'm not sure why I didn't see this before.

However, I'm not that happy with depending on a magic name here - is
there a way we can put this name into a makefile variable?

-- 
Rob Shearman



More information about the wine-devel mailing list