Adding timestamps to log output

Rob Shearman robertshearman at
Fri Oct 10 08:26:59 CDT 2008

2008/10/8 Michael Karcher <wine at>:
> In
> Peter Urbanec sent a patch I like, that adds timing information to the
> log. It has been critized for having the wrong indentation style. As I
> would like to give that patch a second chance, I reindented the code to
> match the surrounding code.
> The question I have: How to give credit? The standard "based on a patch
> from" clause seems to weak to me, as it is aside from whitespace changes
> exactly that patch. But as I did these whitespace changes, it also seems
> wrong to just put Peter Urbanec into the From line. He did never submit
> in that form. I would be happy about any advice.
> The indentation-fixed patch is included, although the first two lines
> are munged to prevent the patch to get away with the "forged"
> attribution.

The accepted way is to include a "From: " line in the body of your
email message stating the original author of the patch.

Rob Shearman

More information about the wine-devel mailing list