ConvertStringSecurityDescriptorToSecurityDescriptor - more tests (pass)
James Hawkins
truiken at gmail.com
Mon Oct 13 16:28:31 CDT 2008
On Mon, Oct 13, 2008 at 4:23 PM, Paul Bryan Roberts
<pbronline-wine at yahoo.co.uk> wrote:
> A second attempt that, I hope, takes into account feedback from James
> Hawkins.
>
> Original correction to ParseStringAclToAcl() to set missing error code
> stands.
>
> Gratuitous setting of invalid parameter withdrawn.
>
> Replaced with check for NULL on StringSecurityDescriptor parameter in both A
> and W forms of ConvertStringSecurityDescriptorToSecurityDescriptor.
>
> New checks backed up by additional test cases.
>
> Two instances of "highly superfluous" TRACE removed as suggested by JH,
>
> Issue - unable to add test cases that show
>
> if (GetVersion() & 0x80000000)
> SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
>
> should precede checks for NULL parameters. What to do ? Drop patch
> altogether ?
>
+ if (GetVersion() & 0x80000000)
+ SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
Where are you getting this from?
--
James Hawkins
More information about the wine-devel
mailing list