Patchwatcher: failed regression tests: [2/3] oleaut32: return correct error code

Kirill K. Smirnov lich at math.spbu.ru
Thu Oct 16 06:54:54 CDT 2008


  Hello

>@@ -1802,7 +1802,7 @@ static HRESULT WINAPI 
>OLEPictureImpl_Load(IPersistStream* iface,IStream*pStm) {
>       hr=IStream_Read(pStm,header,8,&xread);
>       if (hr || xread!=8) {
>           ERR("Failure while reading picture header (hr is %x, nread is %d).
\n",hr,xread);
>-          return hr;
>+          return (hr?hr:E_FAIL);
>       }
>       headerread += xread;
>       xread = 0;

Hmm... I've just got notification from patchwalker that this patch for 
oleaut32 breaks some tests for gdiplus. I do not know why it does happen.
But since this patch fixes some bugs and it got accepted, please, do not 
revert it or do anything evil :-)) I hope I will find right solution soon.

--
Kirill



More information about the wine-devel mailing list