[PATCH 03/10] jscript: Added NaN value implementation.

Rob Shearman robertshearman at gmail.com
Fri Oct 17 05:32:24 CDT 2008


2008/10/16 David Laight <david at l8s.co.uk>:
> On Wed, Oct 15, 2008 at 04:50:30PM -0500, Jacek Caban wrote:
>> Alexandre Julliard wrote:
>> >I'd suggest to take advantage of the variant union instead of copying
>> >all these glibc definitions. Something like
>> >
>> >#ifdef NAN
>> >    V_R8(&vt) = NAN;
>> >#else
>> >    V_I8(&vt) = nan_magic_pattern;
>> >#endif
>> >
>>
>> The problem is that nan_magic_pattern would have to be 8 bytes and AFAIK
>> there is no portable way to do it without ugly casts like in attached patch.
>
> And that break C's 'strict aliasing' rules that gcc might apply
> when optimising code.

Wine is compiled without strict aliasing already.

-- 
Rob Shearman



More information about the wine-devel mailing list