[PATCH] uxtheme: fixed the todo blocks in the SetWindowTheme tests. [try 2]
Rob Shearman
robertshearman at gmail.com
Tue Oct 28 10:17:10 CDT 2008
2008/10/28 James Hawkins <truiken at gmail.com>:
> + HRESULT hr = S_OK;
> TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName),
> debugstr_w(pszSubIdList));
> - hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName);
> + if(!IsWindow(hwnd))
> + hr = E_HANDLE;
> + if(SUCCEEDED(hr))
> + hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName);
> if(SUCCEEDED(hr))
> hr = UXTHEME_SetWindowProperty(hwnd, atSubIdList, pszSubIdList);
> if(SUCCEEDED(hr))
>
> This code is screaming for a goto.
I disagree.
--
Rob Shearman
More information about the wine-devel
mailing list