patchwatcher: the winehttp:notification tests are failing for some reason

Hans Leidekker hans at codeweavers.com
Tue Oct 28 10:22:14 CDT 2008


On Tuesday 28 October 2008 14:02:15 Dan Kegel wrote:

> > I guess we could increase sleep between two tests that query the same
> > host once more, or just pick another host.
>
> Any test that uses the public internet is buggy
> and is bound to fail often enough to annoy people
> when run as part of an automated test system; that's
> http://bugs.winehq.org/show_bug.cgi?id=15716
> I suspect that's what's happening here.

Funny thing is that as we speak codeweavers.com is being
slashdotted and some of the wininet and winhttp test fail
because of that ;)

But I don't think we want to give up on this type of test
coverage though, precisely because it exercises failure
paths better, in tests and core Wine code.
 
(This particular test failure is not one of those BTW, its
a cache effect that you would also see when testing a local
server.)

> Since only automated test systems run these
> tests, we could have an optional shell script, run manually
> on systems that have to run the tests really reliably,
> that sets up a local server and adds entries to /etc/hosts.

I'm all for this option; it would give more control over the
tests, and being able to inspect a server log file is invaluable
too.

 -Hans




More information about the wine-devel mailing list