[PATCH 4/5] wined3d: Remove glDrawBuffer calls in BltOverride.

Henri Verbeet hverbeet at gmail.com
Tue Sep 2 14:44:29 CDT 2008

2008/9/2 Alexander Dorofeyev <alexd4 at inbox.lv>:
> I don't think this is possible yet, the variable is also used for some
> window/screen and upside-down coordinate magic. I do suspect that the code doing
> so may need to be fixed or removed, because it looks inconsistent with code in
> e.g. ClearSurface (device.c) and doesn't seem to work correctly with windowed
> ddraw. But it probably must be done in another patch. Setting buffer for
> offscreen surface case could be removed though, as it doesn't do anything after
> removal of glDrawBuffer.
After this patch it would only be used to check if the surface is the
frontbuffer by comparing it to GL_FRONT. That doesn't make sense of

if(buffer == GL_FRONT) {
should be replaced with
if ((IWineD3DSurface *)This == dstSwapchain->frontBuffer) {

More information about the wine-devel mailing list