wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

Henri Verbeet hverbeet at
Wed Sep 3 07:25:08 CDT 2008

2008/9/3 Jeff Zaroyko <jeffzaroyko at>:
> Please ignore the previous patch sent two days ago, this one fixes a
> performance regression as well as removing the memory leak.
> -Jeff
Do you have some kind of benchmark data for this change? I don't think
allocating relatively large buffers like that on the stack is a good
idea. If it does make a lot of difference in terms of performance, it
probably makes sense to allocate the buffer in arbfp_alloc() instead
and just reuse it. In that case it probably also makes sense to do
that for the ARB and GLSL shader backends as well.

More information about the wine-devel mailing list