msi: Uninitialized variable fix (Coverity)

[James Hawkins]

On Tue, Sep 9, 2008 at 4:24 PM, Andrew Talbot
<Andrew.Talbot at talbotville.com> wrote:
> James Hawkins wrote:
>
>> On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot
>> <andrew.talbot at talbotville.com> wrote:
>>> Fix for Coverity error CID: 762.
>>>
>>> [...]
>>> -    RegCloseKey(userdata);
>>> +    if (userdata) RegCloseKey(userdata);
>>>     return rc;
>>
>> Please don't add another NULL-before-free check.
>>
>
> Hi James,
>
> Sorry, I don't understand what I have done wrong. RegCloseKey() will return ERROR_INVALID_HANDLE if called with hkey==NULL.
>

...and we don't care what value it returns.

-- 
James Hawkins