dplayx: Fix static overrun of pDP array in test. (Coverity)

Kai Blin kai.blin at gmail.com
Thu Sep 11 16:47:54 CDT 2008


On Thursday 11 September 2008 20:50:58 Ismael Barros wrote:
> On 9/10/08, Kai Blin <kai.blin at gmail.com> wrote:
> > ---
> >  dlls/dplayx/tests/dplayx.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
>
> Sorry for the delay, I should have checked this before. I hadn't even
> read the coverity thread.
>
> The patch is incorrect, because EnumSessions_cb_join always receives a
> LPDIRECTPLAY4 as lpContext argument, even if most callbacks receive a
> lpCallbackData. The initialization of callbackData before the call was
> an error on my side.
>
> This patch fixes the double error.

Just the reason why I cc'ed you on this patch. :)

Thanks,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080911/d1b35a93/attachment.pgp 


More information about the wine-devel mailing list