msvcrt: scanf fix a typo

Paul Vriens paul.vriens.wine at gmail.com
Fri Sep 19 17:14:33 CDT 2008


James Hawkins wrote:
> On Fri, Sep 19, 2008 at 4:59 PM, Austin English <austinenglish at gmail.com> wrote:
>> Relevant code:
>>    /* check %p with no hex digits */
>>    ok( sscanf("1233", "%p", &ptr) == 1, "sscanf failed\n"  );
>>    ok( ptr == (void *)0x1233,"sscanf reads %p instead of %x\n", ptr, 0x1233 );
>>
>>    ok( sscanf("1234", "%P", &ptr) == 1, "sscanf failed\n"  );
>>    ok( ptr == (void *)0x1234,"sscanf reads %p instead of %x\n", ptr, 0x1234 );
>>
>>
>> Comment reads %p. All the other chars are lower case, and you can see
>> the values are different (1233 vs 1234).
>>
> 
> I'm still positive the original author meant to use capital P.
> There's no point in adding yet another test for a number that is
> different by one digit.
> 
I have to agree with James here. The original author (Peter Oberndorfer) 
added the tests and an implementation of %p and %P.

Commits:

02fb99e6b360a6f321f716b57df97ca79ec1b9f3
9e3a4652dafbcf1f3f957858a54f2149e91942b7

-- 
Cheers,

Paul.



More information about the wine-devel mailing list